From: tsteven4 <tsteven4@gmail.com>
Date: Sun, 3 Mar 2019 17:46:54 +0000 (-0700)
Subject: clang-tidy readability-simplify-boolean-expr on gui.
X-Git-Tag: archive/raspbian/1.10.0+ds-2+rpi1~1^2~12^2~8^2~32^2~4
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success/%22http:/www.example.com/cgi/success?a=commitdiff_plain;h=0d47850279b89e010ed33b670165b9efd4c85644;p=gpsbabel.git

clang-tidy readability-simplify-boolean-expr on gui.
---

diff --git a/gui/format.cc b/gui/format.cc
index 6607bd4af..b609e7a4a 100644
--- a/gui/format.cc
+++ b/gui/format.cc
@@ -70,7 +70,7 @@ void Format::restoreSettings(QSettings& settings)
 void Format::setToDefault()
 {
   for (int i=0; i<inputOptions_.size(); i++) {
-    if (inputOptions_[i].getType() == FormatOption::OPTbool && inputOptions_[i].getDefaultValue().toBool() == true) {
+    if (inputOptions_[i].getType() == FormatOption::OPTbool && inputOptions_[i].getDefaultValue().toBool()) {
       inputOptions_[i].setSelected(true);
     } else {
       inputOptions_[i].setSelected(false);
@@ -78,7 +78,7 @@ void Format::setToDefault()
     inputOptions_[i].setValue(QVariant());
   }
   for (int i=0; i<outputOptions_.size(); i++) {
-    if (outputOptions_[i].getType() == FormatOption::OPTbool && outputOptions_[i].getDefaultValue().toBool() == true) {
+    if (outputOptions_[i].getType() == FormatOption::OPTbool && outputOptions_[i].getDefaultValue().toBool()) {
       outputOptions_[i].setSelected(true);
     } else {
       outputOptions_[i].setSelected(false);
diff --git a/gui/gmapdlg.cc b/gui/gmapdlg.cc
index c69177ae5..d38948410 100644
--- a/gui/gmapdlg.cc
+++ b/gui/gmapdlg.cc
@@ -498,7 +498,7 @@ void GMapDialog::showOnlyThisWaypoint()
 {
   QList <GpxWaypoint>& tlist = gpx_.getWaypoints();
   for (int i=0; i<tlist.size(); i++) {
-    tlist[i].setVisible(i == menuIndex_? true: false);
+    tlist[i].setVisible(i == menuIndex_);
     trkList_[i]->setCheckState(i==menuIndex_? Qt::Checked: Qt::Unchecked);
   }
   wptItem_->setCheckState(Qt::Checked);
@@ -509,7 +509,7 @@ void GMapDialog::showOnlyThisTrack()
 {
   QList <GpxTrack>& tlist = gpx_.getTracks();
   for (int i=0; i<tlist.size(); i++) {
-    tlist[i].setVisible(i == menuIndex_? true: false);
+    tlist[i].setVisible(i == menuIndex_);
     trkList_[i]->setCheckState(i==menuIndex_? Qt::Checked: Qt::Unchecked);
   }
   trkItem_->setCheckState(Qt::Checked);
@@ -521,7 +521,7 @@ void GMapDialog::showOnlyThisRoute()
 {
   QList <GpxRoute>& rlist = gpx_.getRoutes();
   for (int i=0; i<rlist.size(); i++) {
-    rlist[i].setVisible(i == menuIndex_? true: false);
+    rlist[i].setVisible(i == menuIndex_);
     rteList_[i]->setCheckState(i==menuIndex_? Qt::Checked: Qt::Unchecked);
   }
   rteItem_->setCheckState(Qt::Checked);
diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index 26490c7ac..3e7a9723a 100644
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -849,9 +849,9 @@ bool MainWindow::isOkToGo()
     return false;
   }
 
-  if (babelData_.outputType_ == BabelData::noType_ && babelData_.previewGmap_ == true) {
+  if (babelData_.outputType_ == BabelData::noType_ && babelData_.previewGmap_) {
   }
-  if (babelData_.outputType_ == BabelData::noType_ && babelData_.previewGmap_ == false) {
+  if (babelData_.outputType_ == BabelData::noType_ && !babelData_.previewGmap_) {
     QMessageBox::information(nullptr, QString(appName), tr("No valid output specified"));
     return false;
   } else if (babelData_.outputType_ == BabelData::fileType_ &&